[seungseung88] WEEK 02 solutions#1203
Merged
seungseung88 merged 9 commits intoDaleStudy:mainfrom Apr 13, 2025
seungseung88:main
Merged
[seungseung88] WEEK 02 solutions#1203seungseung88 merged 9 commits intoDaleStudy:mainfrom seungseung88:main
seungseung88 merged 9 commits intoDaleStudy:mainfrom
seungseung88:main
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name (e.g., 'freq') to better convey that it represents character frequency differences.
for (const i of Object.values(count)) {
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name like 'countValue' or 'frequency' to improve code readability.
for (const i of Object.values(count)) {
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name, such as 'frequency', to improve code clarity.
for (const i of Object.values(count)) {
climbing-stairs/seungseung88.js:8
- [nitpick] Consider renaming 'arr' to a more descriptive variable like 'dp' or 'steps' to clarify its purpose as a dynamic programming array.
const arr = [1, 2];
Contributor
grapefruitgreentealoe
left a comment
grapefruitgreentealoe
left a comment
There was a problem hiding this comment.
시간, 공간복잡도 효율을 생각하며 잘 작성해주신 거 같습니다 LGTM!
| count[t[i]] = (count[t[i]] || 0) - 1; | ||
| } | ||
|
|
||
| for (const i of Object.values(count)) { |
Contributor
There was a problem hiding this comment.
for in 연산으로 바꾸셔서 Object.values 메소드 배열 생성으로 인한 비용을 줄여서 작성하시면 더 효율적일 거 같습니다!
grapefruitgreentealoe
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!